Remove a truckload of wasteful CSS #266
Conversation
| @@ -120,7 +120,7 @@ | |||
| list-style: none; | |||
| // | |||
| &:hover { | |||
| background: $black; | |||
| background: rgba($black,.5); | |||
There was a problem hiding this comment.
.5 should be written with a leading zero as 0.5
Commas in function arguments should be followed by a single space
There was a problem hiding this comment.
scss-lint says to do the opposite of both of those. Also, I'm hoping the horrible flip grid will be removed soon anyway, so I'm not going to fix this.
|
Just looking into configuring Hound to Assembly style. |
|
@chrislloyd With the semicolon, that's actually necessary. (It's ok since there isn't another But yeah, that'd be awesome. |
|
I just pulled this down and it looks like border colors are off:
Also, it looks like borders on the footer are extending wide:
and the about page looks a little off:
|
|
Sorry @chrislloyd!
|
|
|
It seemed that the owl imports were causing the merge conflicts, but even removing those I can't get things to work. Any other ideas @chrislloyd? |
|
How's this looking? Would love to merge :D |
|
Yeah, definitely. How can I figure out what the conflicts are? |
|
Try rebasing this branch This should give you a bunch of merge conflicts. Resolve those and then: Then force push the branch: |
These are being overridden in the browser by `utilities/_type`
|
@whatupdave I think I’ve fixed it up, thanks for that! |
|
@whatupdave @mdeiters @chrislloyd Let’s get this merged :) |
|
@whatupdave is out today but we'll get this merged soon @lachlanjc :D |
| if (this.isShown && this.options.backdrop) | ||
| { | ||
| var doAnimate = $.support.transition && animate; | ||
|
|
||
| this.$backdrop = $('<div class="modal-backdrop ' + animate + '" />') | ||
| .appendTo(document.body); | ||
| this.$backdrop = $("<div class='bg-black " + animate + "' />").appendTo(document.body); |
| var transition = $.support.transition && that.$element.hasClass('fade'); | ||
| this.preloadSize(function() { | ||
| that.backdrop(function () { | ||
| var transition = $.support.transition && that.$element.hasClass("muted"); |
| @@ -99,6 +100,11 @@ let ProductsHandlers = { | |||
| type: ActionTypes.PRODUCT_RECEIVE, | |||
| product: product | |||
| }); | |||
|
|
|||
| Dispatcher.dispatch({ | |||
There was a problem hiding this comment.
Expected ',' and instead saw '.'.
Expected ',' and instead saw '('.
Expected an identifier and instead saw '{'.
|
@whatupdave Travis says we’re using a deprecated method for email delivery here: |
|
Ok, we should be good to go for CSS here. |
|
There's one little issue on the padding of bounty lists. I've fixed it but have no Wi-Fi on my 💻. I'll push it up this afternoon (along with another new PR). |
|
Ok, issue fixed! |
| @@ -58,7 +58,7 @@ a.deprecated-card:hover { | |||
| padding: 20px; | |||
| } | |||
|
|
|||
| .deprecated-card-footer { | |||
| .deprecated-bg-gray-5 py2 px1 { | |||
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
| @include transition-timing-function($transition-function); | ||
| } | ||
| .deprecated-card-inner { | ||
| position: absolute; |
There was a problem hiding this comment.
Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Properties should be ordered background-position, background-size, display, height, opacity, position, width
lachlanjc
changed the title
lachlanjc
changed the title
I've searched the entire app for every class I've removed, and almost all the classes weren't being used at all. Lots more coming.