Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty body check #1

Merged
merged 3 commits into from Feb 6, 2021
Merged

fix empty body check #1

merged 3 commits into from Feb 6, 2021

Conversation

JleMyP
Copy link
Contributor

@JleMyP JleMyP commented Jan 31, 2021

I got an error when I sent a request DELETE and response body was empty

@assemmarwan assemmarwan added the bug Something isn't working label Feb 1, 2021
Copy link
Owner

@assemmarwan assemmarwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JleMyP Thanks for creating a PR on discovering the bug 😄.

Just need to address the below please

lib/src/dio_http_formatter_base.dart Outdated Show resolved Hide resolved
lib/src/dio_http_formatter_base.dart Outdated Show resolved Hide resolved
@assemmarwan assemmarwan merged commit 9811205 into assemmarwan:master Feb 6, 2021
@hrxiang hrxiang mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants