Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try_ variants of Assert methods #128

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Add try_ variants of Assert methods #128

merged 1 commit into from
Jul 31, 2021

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Jul 31, 2021 •
edited by epage
Loading

Closes #127

epage
epage approved these changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smoelius
Copy link
Contributor Author

^ Is this the right way to satisfy "Lint Commits?"

@epage
Copy link
Contributor

epage commented Jul 31, 2021

Yes. Thanks. Normally I give contributors a pass and fix it when merging.

@epage epage merged commit 1e3c52f into assert-rs:master Jul 31, 2021
@smoelius
Copy link
Contributor Author

Thanks, @epage!

This was referenced Jul 31, 2021
Merged
Merged
@epage epage mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question regarding "flaky" commands
2 participants
@smoelius @epage