Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Predicate from implementations #30

Closed
epage opened this issue Apr 27, 2018 · 0 comments
Closed

Decouple Predicate from implementations #30

epage opened this issue Apr 27, 2018 · 0 comments
Assignees
Labels
enhancement Improve the expected
Milestone

Comments

@epage
Copy link
Contributor

epage commented Apr 27, 2018

assert_cli is going to optionally allow users to create predicates for verifying the results of their application.

My current thoughts are

  • Allow users to decide if they want predicates and, if so, which
  • Minimize predicate API breakages from impacting assert_cli's API

From this, my thought is that we should move Predicate into a predicates-core crate. assert_cli will accept a predicates_core::Predicate. Users of assert_cli can then depend on predicates if they want and pass some in. This will allow us to make breaking changes to the predicates without breaking the APIs that accept predicates.

@epage epage added the enhancement Improve the expected label Apr 27, 2018
@epage epage added this to the 0.4 milestone Apr 27, 2018
@epage epage self-assigned this Jul 27, 2018
epage added a commit to epage/predicates-rs that referenced this issue Jul 30, 2018
epage added a commit to epage/predicates-rs that referenced this issue Jul 30, 2018
epage added a commit to epage/predicates-rs that referenced this issue Jul 30, 2018
epage added a commit to epage/predicates-rs that referenced this issue Jul 30, 2018
@epage epage closed this as completed in #64 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

1 participant