Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor src/path/fs predicates. #56

Closed
epage opened this issue Jul 14, 2018 · 2 comments
Closed

Refactor src/path/fs predicates. #56

epage opened this issue Jul 14, 2018 · 2 comments
Labels
enhancement Improve the expected

Comments

@epage
Copy link
Contributor

epage commented Jul 14, 2018 •
edited
Loading

I realized, we could reuse these predicates for being able to create file-backed eq predicates for strings / bytes.

Other changes

  • Add find_case to it
  • Switch the equality check to use difference.
@epage epage added enhancement Improve the expected breaking-change labels Jul 14, 2018
@epage epage mentioned this issue Jul 19, 2018
Closed
epage added a commit to epage/predicates-rs that referenced this issue Jul 20, 2018
@epage
feat(path): support file-based str predicates
4b43053 
Fixes assert-rs#56
@epage epage mentioned this issue Jul 20, 2018
Merged
@epage
Copy link
Contributor Author

epage commented Jul 20, 2018

Realized I could get this in now without disrupting my big PR or breaking compatibility by just adding additional impls.

I'll need to remember when I add find_case support for use difference.

@epage epage closed this as completed in #59 Jul 20, 2018
@epage
Copy link
Contributor Author

epage commented Jul 20, 2018

Just kicked off cargo publish for v0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage