feat(snap): Jsonlines support #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like ndjson was merged into jsonlines, so went with that. One difference at one point was allowing blank lines from what I've heard. I'm not seeing it mentioned in jsonlines but went with supporting it. Part of assert-rs#92
3 tasks
32 tasks
epage
added a commit
to epage/snapbox
that referenced
this pull request
May 23, 2024
Looks like ndjson was merged into jsonlines, so went with that. One difference at one point was allowing blank lines from what I've heard. I'm not seeing it mentioned in jsonlines but went with supporting it. Part of assert-rs#92 Cherry pick ae6bce4 (assert-rs#277) Cherry pick 62ddc26 (assert-rs#290)
epage
added a commit
to epage/snapbox
that referenced
this pull request
May 23, 2024
Cherry pick e7ef941 (assert-rs#277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like ndjson was merged into jsonlines, so went with that.
One difference at one point was allowing blank lines from what I've
heard. I'm not seeing it mentioned in jsonlines but went with
supporting it.
Part of #92