[Simplification] Remove global options in plugin in favour of source-… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set specific *only* This removes the complicated "global" options in favour of a simpler "source-set" specific set of options intead. This was extracted as part of a refactor to update this project to use modern gradle paradigms. Extracted from #29.
Nava2
commented
Apr 21, 2023
|
|
||
| implementation("com.google.guava:guava:31.1-jre") | ||
| testCompileOnly("org.jetbrains:annotations:24.0.1") |
There was a problem hiding this comment.
Only change here was this
Nava2
commented
Apr 21, 2023
| buildFile.delete() | ||
| TestUtils.buildFile(buildFile, """ | ||
| assertJ { |
There was a problem hiding this comment.
All of these changes are replacing a "global config" with a source-set specific version.
scordio
approved these changes
Apr 22, 2023
| provided by the [AssertJ Generator Maven Plugin](http://joel-costigliola.github.io/assertj/assertj-assertions-generator-maven-plugin.html). | ||
|
|
||
| provided by | ||
| the [AssertJ Generator Maven Plugin](http://joel-costigliola.github.io/assertj/assertj-assertions-generator-maven-plugin.html). |
There was a problem hiding this comment.
I just realized we still host the generator documentation at the old website, I raised assertj/doc#139 to track this.
10 tasks
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set specific only
Related to #17, extracted from #29.
This removes the complicated "global" options in favour of a simpler "source-set" specific set of options instead. When fixing the default options, the path was updated from
generated-srcs/test/javatogenerated-srcs/${sourceSet.name}-test/javaas this is more accurate to what these sources are.This was extracted as part of a refactor to update this project to use modern gradle paradigms (#29).