Added assertions for LocalDate #20
Conversation
* isAfter * isAfterOrEqualTo * isBefore * isBeforeOrEqualTo * isEqualTo * isIn * isNotEqualTo * isNotIn * hasYear * hasMonthOfYear * hasDayOfYear
gd-estrepetov
changed the title
|
@joel-costigliola, please review |
| } | ||
|
|
||
| @Test | ||
| public void test_isAfterOrEqual_assertion_error_message() { |
There was a problem hiding this comment.
Since assertj-joda-time relies on assertj-core 3.x, we can take advantage to catchThrowable, that will make the test easier to read and not having to use failBecauseExpectedAssertionErrorWasNotThrown.
I'm keen on using a BBD style test (GIVEN, WHEN THEN).
This comment applies to any other test checking for an expected AssertionError
There was a problem hiding this comment.
Refactored to assertThatThrownBy() everywhere it is applicable
|
|
||
| @Test | ||
| public void should_fail_if_both_actual_and_parameter_are_null() { | ||
| expectException(AssertionError.class, actualIsNull()); |
There was a problem hiding this comment.
no need to use catchThrowable, the test is short enough to be readable (even though I'm not a big fan of expectException coming as the first instruction making the test a THEN, GIVEN, WHEN instead of GIVEN, WHEN, THEN).
| * Verifies that the month of the actual {@code LocalDate} is equal to the given month | ||
| * <p> | ||
| * Example : | ||
| * <pre><code class='java'> assertThat(new LocalDate(2018,1,1)).hasDayOfMonth(1);</code></pre> |
There was a problem hiding this comment.
let's use a month != 1 to make it crystal clear that we check the day of month and not the month.
|
|
||
| /** | ||
| * Same assertion as {@link #isAfter(LocalDate)} but the {@link LocalDate} is built from given a String that | ||
| * must follow ISO8601 format (yyyy-MM-dd)to allow calling {@link LocalDate#LocalDate(Object) LocalDate(Object)} |
There was a problem hiding this comment.
missing space (yyyy-MM-dd)to -> (yyyy-MM-dd) to
|
@gd-estrepetov thanks for the PR, first round of review done! |
|
@joel-costigliola fixed all comments |
|
Integrated, many thanks @gd-estrepetov! |
I have added following assertions for LocalDate