Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #162 #163

Merged
merged 12 commits into from
Apr 13, 2023
Merged

Fixes #162 #163

merged 12 commits into from
Apr 13, 2023

Conversation

mchmielarz
Copy link
Collaborator

No description provided.

@mchmielarz mchmielarz added this to the v0.4.1 milestone Oct 7, 2021
@mchmielarz mchmielarz self-assigned this Oct 7, 2021
@mchmielarz mchmielarz modified the milestones: v0.4.1, v0.4.3 Oct 7, 2021
@mchmielarz
Copy link
Collaborator Author

@pivovarit Would you look at it too? :D

Copy link
Collaborator

@Grandys Grandys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments regarding documentation, code looks good 👍

@Opalo
Copy link

Opalo commented Apr 11, 2023

WUT :D What happens here? It's still not merged, after a year and a half? :D

@mchmielarz
Copy link
Collaborator Author

@Opalo I've been waiting for the review for whole this time (pun intended) ;)

@mchmielarz mchmielarz force-pushed the feature/162-validation-satisfying-condition branch from 1def0e7 to 3a1724e Compare April 12, 2023 20:51
@mchmielarz mchmielarz requested a review from Grandys April 12, 2023 21:57
Copy link
Collaborator

@Grandys Grandys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mchmielarz mchmielarz merged commit 63f907f into main Apr 13, 2023
8 checks passed
@mchmielarz mchmielarz deleted the feature/162-validation-satisfying-condition branch April 13, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants