Skip to content

Commit

Permalink
docs: AbstractOffsetDateTimeAssert#isBetween parameter names should u…
Browse files Browse the repository at this point in the history
…se `inclusive`, not `exclusive` (#3217)
  • Loading branch information
radistao committed Oct 12, 2023
1 parent 4ba4718 commit 519761d
Showing 1 changed file with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -854,8 +854,8 @@ public SELF isInTheFuture() {
* .isBetween(parse("2010-01-01T01:00:00+01:00"),
* parse("2010-01-01T01:00:00+01:00"));</code></pre>
*
* @param startExclusive the start value (exclusive), expected not to be null.
* @param endExclusive the end value (exclusive), expected not to be null.
* @param startInclusive the start value (inclusive), expected not to be null.
* @param endInclusive the end value (inclusive), expected not to be null.
* @return this assertion object.
* @throws AssertionError if the actual value is {@code null}.
* @throws NullPointerException if start value is {@code null}.
Expand All @@ -864,8 +864,8 @@ public SELF isInTheFuture() {
*
* @since 3.7.1
*/
public SELF isBetween(OffsetDateTime startExclusive, OffsetDateTime endExclusive) {
comparables.assertIsBetween(info, actual, startExclusive, endExclusive, true, true);
public SELF isBetween(OffsetDateTime startInclusive, OffsetDateTime endInclusive) {
comparables.assertIsBetween(info, actual, startInclusive, endInclusive, true, true);
return myself;
}

Expand All @@ -892,8 +892,8 @@ public SELF isBetween(OffsetDateTime startExclusive, OffsetDateTime endExclusive
* // assertion fails:
* assertThat(firstOfJanuary2000).isBetween("1999-01-01T00:00:01Z", "1999-12-31T23:59:59Z");</code></pre>
*
* @param startExclusive the start value (exclusive), expected not to be null.
* @param endExclusive the end value (exclusive), expected not to be null.
* @param startInclusive the start value (inclusive), expected not to be null.
* @param endInclusive the end value (inclusive), expected not to be null.
* @return this assertion object.
*
* @throws AssertionError if the actual value is {@code null}.
Expand All @@ -904,8 +904,8 @@ public SELF isBetween(OffsetDateTime startExclusive, OffsetDateTime endExclusive
*
* @since 3.7.1
*/
public SELF isBetween(String startExclusive, String endExclusive) {
return isBetween(parse(startExclusive), parse(endExclusive));
public SELF isBetween(String startInclusive, String endInclusive) {
return isBetween(parse(startInclusive), parse(endInclusive));
}

/**
Expand Down

0 comments on commit 519761d

Please sign in to comment.