Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isUpperCase() and isLowerCase to AbstractCharSequenceAssert #1106

Closed
marceloverdijk opened this issue Nov 1, 2017 · 4 comments
Closed
Milestone

Comments

@marceloverdijk
Copy link

Summary

Add isUpperCase() and isLowerCase to AbstractCharSequenceAssert.
Just like AbstractCharacterAssert also has these.

Example

assertThat("ABC").isUpperCase(); // --> currently not possible

assertThat('A').isUpperCase(); // --> currently already possible

Java 8 specific ?

  • YES : create Pull Request from the master branch
  • NO : create Pull Request from the 2.x branch
@joel-costigliola
Copy link
Member

Sure no problem.
Do you want to contribute ?

@marceloverdijk
Copy link
Author

Yes fine, I will create a PR later.

@marceloverdijk
Copy link
Author

marceloverdijk commented Nov 1, 2017

Should I take the master branch as basis?

@marceloverdijk
Copy link
Author

I created PR #1107 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants