New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Path assertions #158
Comments
Yes, for the time being AssertJ is java 6 compatible because a lot of projects still use java 6. This issue could indeed be addressed in java 7 module that would provide all existing java 6 assertions and add new ones specific to java 7, users would then choose either assertj-core or assertj-core-java7 whether they use java 6 or 7. As I see it, such a module would contain only java 7 assertions and provide java 6 assertions from classic assertj-core (probably by delegation). If such a solution is possible (I think it is but we need to try it to be sure), I'm ok to create the module. What I don't want here is to duplicate code because it would be a pain to maintain ... but I like the idea which is clearly in AssertJ philosophy that is providing assertions for the most used types. |
+1 for the additional module |
Java 6 is EOL. If people want to use it on a Java 6 projects they can remain on an older version. I'll +1 whatever gives me |
I wanted to create a specific module for Java 7 but as Java 6 is EOL I will just upgrade the code to Java 7 in the next release (2.0.0), 1.7.x versions are the last versions based Java 6 . Java 8 support is coming, we have a dedicated branch for that, issues are labeled with Java 8. |
Woo \o/. I'll try to take a look and help out where I can. |
Very happy to see this element coming in my favorite assertion library ! |
FYI, this issue is being addressed by #303. |
Bumps [maven-deploy-plugin](https://github.com/apache/maven-deploy-plugin) from 2.8.2 to 3.0.0. - [Release notes](https://github.com/apache/maven-deploy-plugin/releases) - [Commits](apache/maven-deploy-plugin@maven-deploy-plugin-2.8.2...maven-deploy-plugin-3.0.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-deploy-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The only file-related assertions I could find are for pre-java7 API, thus using the File class .
Allowing assertion (or create a new one) that allows to use Path would be useful, however that may break pre-java7 compatibility, thus requiring a dedicated module like "assertj-core-java7".
The text was updated successfully, but these errors were encountered: