Small cleanups #1058
Merged
Small cleanups #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add some missing since tags * Make the ConfigurationProvider constructor private * Do some rewording and fix some typos around the new SPI Representation
| * <li>make sure {@code META-INF/services/org.assertj.core.presentation.Representation} is in the runtime classpath, usually putting it in {@code src/main/resources} is enough</li> | ||
| * <li>make sure {@code META-INF/services/org.assertj.core.presentation.Representation} is in the runtime classpath, usually putting it in {@code src/test/resources} is enough</li> | ||
| * <li>we recommend that you extend from the {@link StandardRepresentation} and override the | ||
| * {@link StandardRepresentation#fallbackToStringOf(Object)}. By doing this all the defaults of AssertJ would be applied and you can apply your own customization</li> |
There was a problem hiding this comment.
good one for using src/test/resources, will do it and also override fallbackToStringOf in assertj-examples
|
Good fixes thanks. |
|
No problem. Glad that you liked them, and sorry for not making them earlier, I was supposed to do them in the initial PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some small Javadoc changes and cleanups:
I think that the most important change here is that the
META-INF/servicesfolder needs to be insrc/test/resourcesand notsrc/main/resources. Users usually have a test scoped dependency of AssertJ.I've also fixed some small typos that I saw and I added the recommended way of writing a custom
Representation. I think it is much easier for the users if they just extend theStandardRepresentationand overridefallbackToStringOf(Object)method, this way they won't mess with all the defaults from AssertJ.