Add ConstructorAssert instead of using ClassAssert #1871

phx1999 · 2020-05-11T08:13:17Z

Check List:

Fixes Add ConstructorAssert instead of using ClassAssert #1869
Unit tests : YES / YES / YES
Javadoc with a code example (on API only) :

valery1707 · 2020-07-25T12:06:18Z

src/main/java/org/assertj/core/api/AbstractConstructorAssert.java

+  }
+
+  /**
+   * Verifies that the actual {@code Constructor} is public (has {@code public} modifier).


This assert is testing for private modifier

Suggested change

* Verifies that the actual {@code Constructor} is public (has {@code public} modifier).

* Verifies that the actual {@code Constructor} is private (has {@code private} modifier).

valery1707 · 2020-07-25T12:08:06Z

src/main/java/org/assertj/core/api/AbstractConstructorAssert.java

+  }
+
+  /**
+   * Verifies that the actual {@code Constructor} is public (has {@code public} modifier).


This assert is testing for protected modifier

Suggested change

* Verifies that the actual {@code Constructor} is public (has {@code public} modifier).

* Verifies that the actual {@code Constructor} is protected (has {@code protected} modifier).

valery1707 · 2020-07-25T12:09:45Z

src/main/java/org/assertj/core/api/AbstractConstructorAssert.java

+   * }
+   *
+   * // these assertions succeed:
+   * assertThat(String.class.getDeclaredConstructor()).isPrivate();


Suggested change

* assertThat(String.class.getDeclaredConstructor()).isPrivate();

* assertThat(MyClass.class.getDeclaredConstructor()).isPrivate();

valery1707 · 2020-07-25T12:10:11Z

src/main/java/org/assertj/core/api/AbstractConstructorAssert.java

+   * }
+   *
+   * // these assertions succeed:
+   * assertThat(String.class.getDeclaredConstructor()).isProtected();


Suggested change

* assertThat(String.class.getDeclaredConstructor()).isProtected();

* assertThat(MyClass.class.getDeclaredConstructor()).isProtected();

valery1707 · 2020-07-25T12:17:29Z

src/main/java/org/assertj/core/api/AbstractConstructorAssert.java

+  }
+
+  /**
+   * Verifies that the actual {@code Constructor} is public (has {@code public} modifier).


This description does not describe the real checks

valery1707 · 2020-07-25T12:18:38Z

src/main/java/org/assertj/core/api/AbstractObjectArrayAssert.java

@@ -345,10 +345,11 @@ public SELF hasSameSizeAs(Iterable<?> other) {
   */
  @Override
  public SELF contains(@SuppressWarnings("unchecked") ELEMENT... values) {
-    arrays.assertContains(info, actual, values);
+      arrays.assertContains(info, actual, values);


Extra padding

valery1707 · 2020-07-25T12:18:59Z

src/main/java/org/assertj/core/api/AbstractObjectArrayAssert.java

    return myself;
  }

+


Extra padding

valery1707 · 2020-07-25T12:19:24Z

src/main/java/org/assertj/core/api/AbstractObjectArrayAssert.java

@@ -3160,4 +3161,7 @@ private SELF newObjectArrayAssert(List<ELEMENT> filteredList) {
    return filteredList.toArray(actualCopy);
  }

+//  public boolean hasPublicConstructor(List<ELEMENT> parameters){


Please don't include not implemented parts in PR

valery1707 · 2020-07-25T12:20:06Z

src/main/java/org/assertj/core/api/Assertions.java

+  }
+
+
+


Extra padding

valery1707 · 2020-07-25T12:20:24Z

src/main/java/org/assertj/core/api/AssertionsForClassTypes.java

+  }
+
+
+


Extra padding

valery1707 · 2020-07-25T12:20:56Z

src/main/java/org/assertj/core/api/AssertionsForClassTypes.java

@@ -586,6 +587,13 @@ public static ClassAssert assertThat(Class<?> actual) {
    return new ThrowableAssert(actual);
  }

+


Please add JavaDoc

valery1707 · 2020-07-25T12:21:12Z

src/main/java/org/assertj/core/api/AssertionsForClassTypes.java

@@ -586,6 +587,13 @@ public static ClassAssert assertThat(Class<?> actual) {
    return new ThrowableAssert(actual);
  }

+
+  public static ConstructorAssert assertThat(Constructor actual){


Please add space before {

valery1707 · 2020-07-25T12:21:39Z

src/main/java/org/assertj/core/api/Assumptions.java

+   * @param actual the actual value.
+   * @return the created assumption for assertion object.
+   */
+  public static AbstractConstructorAssert<ConstructorAssert,Constructor> assumeThat(Constructor actual) {


Please add space after ,

joel-costigliola · 2020-08-31T10:56:25Z

@phx1999 can you remove all the xml files from the PR and address @valery1707 comments? thanks!

phx1999 added 13 commits May 4, 2020 12:54

add assert constructors

b05cadc

add assert constructors

c324910

add assert constructors

2ebaea2

add assert constructors

ad10e42

modify doc

20b0f4e

update

3ec0246

new branch

e3b46be

add ConstructorAssert

c957279

solve conflic

07d2839

delete ConstructorTest

9cdc1d2

add ConstructorAssert test

1895a68

update doc

d0e0d17

update doc

357d95a

phx1999 mentioned this pull request May 11, 2020

Add ConstructorAssert instead of using ClassAssert darkliang/assertj-core#12

Closed

phx1999 added 2 commits May 11, 2020 22:06

update code style

4c86962

modify comment

78ffbbc

phx1999 mentioned this pull request May 31, 2020

Constructor assert darkliang/assertj-core#14

Open

joel-costigliola changed the base branch from master to main June 21, 2020 05:32

valery1707 reviewed Jul 25, 2020

View reviewed changes

joel-costigliola force-pushed the main branch from fe4d0ed to 31080ec Compare August 13, 2020 11:25

scordio force-pushed the main branch from 31080ec to 7e64a5f Compare August 14, 2020 04:46

joel-costigliola added the status: not ready A change that requires additional work label Aug 31, 2020

scordio force-pushed the main branch from d6364ce to 5fc69d0 Compare August 13, 2021 13:20

scordio force-pushed the main branch from 05d979e to b94dc51 Compare October 23, 2021 06:41

scordio force-pushed the main branch from a43399a to addf7d2 Compare June 17, 2022 23:03

scordio force-pushed the main branch from d69cd04 to 9902a7a Compare May 20, 2023 15:13

scordio force-pushed the main branch 2 times, most recently from 38c7b4b to 3cde5bf Compare July 20, 2023 15:20

wjbakker mentioned this pull request Jul 31, 2023

Assertions for java.lang.reflect #3130

Open

scordio force-pushed the 3.x branch 2 times, most recently from 301ca01 to c730d18 Compare June 1, 2024 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ConstructorAssert instead of using ClassAssert #1871

Add ConstructorAssert instead of using ClassAssert #1871

phx1999 commented May 11, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

valery1707 Jul 25, 2020

joel-costigliola commented Aug 31, 2020

	* Verifies that the actual {@code Constructor} is public (has {@code public} modifier).
	* Verifies that the actual {@code Constructor} is private (has {@code private} modifier).

	* assertThat(String.class.getDeclaredConstructor()).isPrivate();
	* assertThat(MyClass.class.getDeclaredConstructor()).isPrivate();

		@@ -586,6 +587,13 @@ public static ClassAssert assertThat(Class<?> actual) {
		return new ThrowableAssert(actual);
		}

Add ConstructorAssert instead of using ClassAssert #1871

Are you sure you want to change the base?

Add ConstructorAssert instead of using ClassAssert #1871

Conversation

phx1999 commented May 11, 2020

Check List:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joel-costigliola commented Aug 31, 2020