Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MockPathsBaseTest #2292

Merged
merged 7 commits into from
Aug 15, 2021
Merged

Remove MockPathsBaseTest #2292

merged 7 commits into from
Aug 15, 2021

Conversation

scordio
Copy link
Member

@scordio scordio commented Jul 15, 2021 •
edited
Loading

Notable changes:

  • MockPathsBaseTest is gone, let's test reality!
  • The scope of NioFilesWrapper is now reduced to the methods from java.nio.file.Files that might throw IOException
  • PathsException is gone in favor of UncheckedIOException
  • All tests originally inheriting from MockPathsBaseTest are rewritten with BDD style
  • Some negative cases are failing on Windows (GitHub Actions) --> currently disabled and investigation will be covered by Path tests fail on Windows #2312

@scordio scordio marked this pull request as draft July 15, 2021 14:48
@scordio scordio force-pushed the mock-paths-base-test branch 6 times, most recently from 0b92ee1 to 1346480 Compare July 25, 2021 18:44
@scordio scordio force-pushed the mock-paths-base-test branch 3 times, most recently from ce3b51b to d598618 Compare August 4, 2021 09:20
@scordio scordio force-pushed the mock-paths-base-test branch 2 times, most recently from 2baad5d to 1d71c0d Compare August 7, 2021 21:51
@scordio scordio changed the title Reduce usage of MockPathsBaseTest Remove MockPathsBaseTest Aug 7, 2021
@scordio scordio force-pushed the mock-paths-base-test branch 5 times, most recently from 94ede75 to a787865 Compare August 11, 2021 16:27
joel-costigliola
joel-costigliola reviewed Aug 14, 2021
View reviewed changes
Copy link
Member

@joel-costigliola joel-costigliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @scordio, looks good to me, I just have some minor comments.

src/test/java/org/assertj/core/internal/paths/Paths_assertEndsWithRaw_Test.java Outdated Show resolved Hide resolved
src/test/java/org/assertj/core/internal/paths/Paths_assertEndsWithRaw_Test.java Outdated Show resolved Hide resolved
src/test/java/org/assertj/core/internal/paths/Paths_assertEndsWithRaw_Test.java Show resolved Hide resolved
...a/org/assertj/core/internal/paths/Paths_assertIsDirectoryContaining_with_Predicate_Test.java Outdated Show resolved Hide resolved
src/test/java/org/assertj/core/internal/paths/Paths_assertIsExecutable_Test.java Outdated Show resolved Hide resolved
@scordio scordio force-pushed the mock-paths-base-test branch 2 times, most recently from bcf50f8 to b6cc7c0 Compare August 15, 2021 08:52
@scordio scordio mentioned this pull request Aug 15, 2021
Open
3 tasks
@scordio scordio added this to the 3.21.0 milestone Aug 15, 2021
@scordio scordio marked this pull request as ready for review August 15, 2021 10:46
@scordio scordio merged commit d391e20 into main Aug 15, 2021
@scordio scordio deleted the mock-paths-base-test branch August 15, 2021 10:47
This was referenced Sep 8, 2021
Closed
Open
@scordio scordio added type: improvement A general improvement and removed type: refactoring labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joel-costigliola joel-costigliola joel-costigliola left review comments

Assignees
No one assigned
Labels
type: improvement A general improvement
Projects
None yet
Milestone
3.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scordio @joel-costigliola