Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2570 adding to class assert #2611

Merged
merged 17 commits into from Jul 9, 2022
Merged

Conversation

jessicant
Copy link
Contributor

@jessicant jessicant commented May 12, 2022

Check List:

Following the contributing guidelines will make it easier for us to review and accept your PR.

@nith2001
Copy link
Contributor

nith2001 commented May 18, 2022

Any updates/edits for this? Just wanted to check in

@scordio
Copy link
Member

scordio commented May 18, 2022

Hi @nith2001, thank you for your patience. We are now focusing on releasing 3.23.0 and we will come back to new features once done with that.

@nith2001
Copy link
Contributor

Okay!

@nith2001 nith2001 mentioned this pull request May 27, 2022
5 tasks
@nith2001
Copy link
Contributor

nith2001 commented Jul 5, 2022

Any updates on this PR? Last I remembered, the tests were failing for alternate reasons.

@scordio
Copy link
Member

scordio commented Jul 6, 2022

@nith2001 once more, thanks for your patience!

The PR looks good and the failures are due to some flaky tests, nothing you need to worry about.

There are a few cosmetic changes I'd do like tests following the GIVEN/WHEN/THEN structure and the use of expectAssertionError, I'll take care of them during the merge which I try to get it done in this week.

@scordio scordio self-assigned this Jul 6, 2022
@scordio scordio added this to the 3.24.0 milestone Jul 6, 2022
@scordio scordio merged commit 4307d35 into assertj:main Jul 9, 2022
@scordio
Copy link
Member

scordio commented Jul 9, 2022

Thanks, @jessicant and @nith2001!

A few changes I've applied:

  • GIVEN/WHEN/THEN structure for tests.
  • Assertion implementation moved to AbstractClassAssert as a private method, since it's unlikely it'll ever be shared with other internal parts of AssertJ. This simplifies the overall maintenance.

@nith2001 nith2001 deleted the 2570-adding-to-ClassAssert branch July 12, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more assertion on ClassAssert
3 participants