New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2570 adding to class assert #2611
Conversation
…rtj-core into 2570-adding-to-ClassAssert
Any updates/edits for this? Just wanted to check in |
Hi @nith2001, thank you for your patience. We are now focusing on releasing 3.23.0 and we will come back to new features once done with that. |
Okay! |
Any updates on this PR? Last I remembered, the tests were failing for alternate reasons. |
@nith2001 once more, thanks for your patience! The PR looks good and the failures are due to some flaky tests, nothing you need to worry about. There are a few cosmetic changes I'd do like tests following the GIVEN/WHEN/THEN structure and the use of |
Thanks, @jessicant and @nith2001! A few changes I've applied:
|
Check List:
Following the contributing guidelines will make it easier for us to review and accept your PR.