Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align javadoc stylesheet to be compatible with Java 17 #2621

Closed
wants to merge 8 commits into from

Conversation

scordio
Copy link
Member

@scordio scordio commented May 21, 2022

Fixes #2576

@scordio scordio added this to the 3.23.0 milestone May 21, 2022
@scordio scordio marked this pull request as draft May 21, 2022 07:53
@scordio scordio force-pushed the update_javadoc_stylesheet branch from 5c73de7 to cc3aeb7 Compare May 21, 2022 17:18
@scordio scordio force-pushed the update_javadoc_stylesheet branch from 7c5d2c6 to 5196743 Compare May 21, 2022 20:51
@scordio scordio force-pushed the update_javadoc_stylesheet branch from 67e66a3 to 0b123f1 Compare May 21, 2022 21:05
@@ -434,12 +434,12 @@
<!-- init Highlight -->
<additionalOptions>${javadocAdditionalOptions}</additionalOptions>
<nohelp>true</nohelp>
<show>private</show>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what matters most is to expose the documentation of public and protected elements, which is the default if this parameter is not configured.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@scordio scordio marked this pull request as ready for review May 21, 2022 21:11
@scordio scordio deleted the update_javadoc_stylesheet branch May 22, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix javadoc style on java 17
2 participants