Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving null-safety of isEqualToNormalizingNewlines #2776

Closed
wants to merge 2 commits into from

Conversation

Nacho321
Copy link
Contributor

Improving the null-safety in isEqualToNormalizingNewlines to avoid NPE errors when actual and/or expected are null.

Check List:

marcela-cardona-s pushed a commit to marcela-cardona-s/assertj that referenced this pull request Oct 15, 2022
…ease complexity cyclomatic from 3 to 14 by 3 conditionals
@marcela-cardona-s
Copy link

Hello, I was reviewing the proposed solution and found that the cyclomatic complexity was increased from 3 to 14, so I propose a more optimal solution, keeping the complexity at 3. You can use the "CodeMetrics" plugin in IntelliJ Idea to validate this value. I leave you the commit of my repository where I propose the solution.

@joel-costigliola
Copy link
Member

Thanks @Nacho321 and @marcela-cardona-s, I have integrated this PR wiht both of you as authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve null-safety of isEqualToNormalizingNewlines
4 participants