Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use Bnd feature to write resolved bndrun files to output folder #2902

Merged
merged 1 commit into from Jan 7, 2023

Conversation

bjhargrave
Copy link
Contributor

Bnd 6.4.0 allows writing and reading bndrun files from different folders. So we change to use this feature so that the resolver plugin writes the resolved bndrun file to the target folder and the testing plugin uses the resolved bndrun file from the target folder.

This change means that running the maven build does not modify checked in source (bndrun files).

Check List:

Following the contributing guidelines will make it easier for us to review and accept your PR.

Bnd 6.4.0 allows writing and reading bndrun files from different
folders. So we change to use this feature so that the resolver plugin
writes the resolved bndrun file to the target folder and the testing
plugin uses the resolved bndrun file from the target folder.

This change means that running the maven build does not modify checked
in source (bndrun files).

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@scordio scordio added this to the 3.25.0 milestone Jan 7, 2023
@scordio scordio added the 3rd-party: OSGi An issue related to the OSGi framework label Jan 7, 2023
@scordio scordio merged commit 50c27a7 into assertj:main Jan 7, 2023
@scordio
Copy link
Member

scordio commented Jan 7, 2023

Thanks, @bjhargrave!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd-party: OSGi An issue related to the OSGi framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants