Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isInThePast and isInTheFuture to LocalDate assertions #2933

Conversation

StefanBratanov
Copy link
Contributor

Check List:

Two things I am unsure about:

  • The correctness of the @since version
  • ShouldBeInTheFuture/ThePast error message contains the class name (java.time.LocalDate). This seems to be the behaviour of the MessageFormatter handling dates classes. Is the error message ok like this?

@joel-costigliola
Copy link
Member

Integrated thanks @StefanBratanov for the good work!
I did some minor changes before integrating it

  • no need to use @DisplayName this is now done automatically with a junit custom test naming config
  • updated the javadoc as the example for isInTheFutture was not that nice (came from date assertions that I also updated)

@StefanBratanov
Copy link
Contributor Author

Integrated thanks @StefanBratanov for the good work! I did some minor changes before integrating it

  • no need to use @DisplayName this is now done automatically with a junit custom test naming config
  • updated the javadoc as the example for isInTheFutture was not that nice (came from date assertions that I also updated)

Thank you @joel-costigliola . Will keep in mind for any future contributions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants