Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update misleading parameter name AbstractOffsetDateTimeAssert#isBetween #3217

Merged
merged 2 commits into from Oct 12, 2023
Merged

Update misleading parameter name AbstractOffsetDateTimeAssert#isBetween #3217

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
760876a
Update misleading parameter name:
radistao Oct 11, 2023
32ca67a
fix comment
radistao Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions assertj-core/src/main/java/org/assertj/core/api/AbstractOffsetDateTimeAssert.java
View file
Open in desktop
Expand Up @@ -854,8 +854,8 @@ public SELF isInTheFuture() {
* .isBetween(parse("2010-01-01T01:00:00+01:00"),
* parse("2010-01-01T01:00:00+01:00"));</code></pre>
*
* @param startExclusive the start value (exclusive), expected not to be null.
* @param endExclusive the end value (exclusive), expected not to be null.
* @param startInclusive the start value (exclusive), expected not to be null.
* @param endInclusive the end value (exclusive), expected not to be null.
radistao marked this conversation as resolved.
Show resolved Hide resolved
* @return this assertion object.
* @throws AssertionError if the actual value is {@code null}.
* @throws NullPointerException if start value is {@code null}.
Expand All @@ -864,8 +864,8 @@ public SELF isInTheFuture() {
*
* @since 3.7.1
*/
public SELF isBetween(OffsetDateTime startExclusive, OffsetDateTime endExclusive) {
comparables.assertIsBetween(info, actual, startExclusive, endExclusive, true, true);
public SELF isBetween(OffsetDateTime startInclusive, OffsetDateTime endInclusive) {
comparables.assertIsBetween(info, actual, startInclusive, endInclusive, true, true);
return myself;
}

Expand All @@ -892,8 +892,8 @@ public SELF isBetween(OffsetDateTime startExclusive, OffsetDateTime endExclusive
* // assertion fails:
* assertThat(firstOfJanuary2000).isBetween("1999-01-01T00:00:01Z", "1999-12-31T23:59:59Z");</code></pre>
*
* @param startExclusive the start value (exclusive), expected not to be null.
* @param endExclusive the end value (exclusive), expected not to be null.
* @param startInclusive the start value (exclusive), expected not to be null.
* @param endInclusive the end value (exclusive), expected not to be null.
* @return this assertion object.
*
* @throws AssertionError if the actual value is {@code null}.
Expand All @@ -904,8 +904,8 @@ public SELF isBetween(OffsetDateTime startExclusive, OffsetDateTime endExclusive
*
* @since 3.7.1
*/
public SELF isBetween(String startExclusive, String endExclusive) {
return isBetween(parse(startExclusive), parse(endExclusive));
public SELF isBetween(String startInclusive, String endInclusive) {
return isBetween(parse(startInclusive), parse(endInclusive));
}

/**
Expand Down