Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doesNotContainKey and doesNotContainKeys to Guava Multimap assertions #3334

Merged
merged 8 commits into from
Mar 1, 2024

Conversation

ryber
Copy link
Contributor

@ryber ryber commented Jan 15, 2024

Behavior matches the asserts for regular java.util Map asserts in core.

@ryber ryber force-pushed the multimapnokeys branch 2 times, most recently from 69d7d39 to 111cb11 Compare January 15, 2024 17:54
@joel-costigliola
Copy link
Member

joel-costigliola commented Jan 15, 2024

Thanks @ryber, we will review your PR shortly !

@joel-costigliola
Copy link
Member

Thanks @ryber, first round of code review done, mostly minor stuff ;-)

@ryber
Copy link
Contributor Author

ryber commented Jan 15, 2024

@joel-costigliola feedback pushed up on its own commit. If you would rather I squash them and force push to the branch I can, or you can squash on merge, or you can leave them as different commits of course. I was not sure what your preference was. I think I got everything 😄

@joel-costigliola
Copy link
Member

We usually squash the commits into one to make logical commits, cool if you do it but no problem if you let us

@scordio scordio added this to the 3.26.0 milestone Jan 16, 2024
@scordio scordio added the type: new feature A new feature label Jan 16, 2024
@ryber
Copy link
Contributor Author

ryber commented Jan 16, 2024

thanks @scordio updated with feedback applied

@scordio
Copy link
Member

scordio commented Jan 16, 2024

Thanks for your first contribution, @ryber!

We'll go ahead with the merge after releasing 3.25.2 (expected later this month).

@ryber
Copy link
Contributor Author

ryber commented Jan 16, 2024

@scordio oh sorry! I didn't catch that you suggested a name change. I went ahead and changed it

@scordio scordio changed the title Add doesNotContainKey/s to Guava Multimap asserts Add doesNotContainKey and doesNotContainKeys to Guava Multimap assertions Mar 1, 2024
@scordio scordio merged commit 688b363 into assertj:main Mar 1, 2024
9 checks passed
@scordio
Copy link
Member

scordio commented Mar 1, 2024

Thanks for your first contribution, @ryber!

@ryber ryber deleted the multimapnokeys branch March 1, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants