Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicating maven-javadoc-plugin configuration and CSS files #3371

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Avoid duplicating maven-javadoc-plugin configuration and CSS files #3371

merged 1 commit into from
Feb 19, 2024

Conversation

armandino
Copy link
Contributor

@armandino armandino commented Feb 19, 2024

Check List:

Following the contributing guidelines will make it easier for us to review and accept your PR.

Summary
The assertj-core and assertj-guava modules contain identical Javadoc CSS files and almost identical maven-javadoc-plugin configuration. This PR removes the duplication from poms and moves CSS files to another directory to allow them to be referenced in sub-modules.

@armandino armandino changed the title Avoid duplicating maven-javadoc-plugin configuration and CSS files Avoid duplicating maven-javadoc-plugin configuration and CSS files Feb 19, 2024
pom.xml Outdated Show resolved Hide resolved
@joel-costigliola
Copy link
Member

@armandino that's awesome! I'll take a look at it shortly.

@joel-costigliola joel-costigliola added this to the 3.26.0 milestone Feb 19, 2024
@scordio scordio self-assigned this Feb 19, 2024
@scordio scordio merged commit 7954d3d into assertj:main Feb 19, 2024
11 checks passed
@scordio
Copy link
Member

scordio commented Feb 19, 2024

Thanks, @armandino!

@scordio scordio added the theme: documentation An issue related to documentation label Feb 19, 2024
@armandino armandino deleted the javadoc-plugin branch February 19, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: documentation An issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants