Added assertion for completable future for it to complete within peri… #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mipo256, we will review your PR shortly ! |
|
@mipo256 the code does not compile on java 8 which is AssertJ Core 3.x baseline, can you fix it ? FYI we will bump it to java 17 for 4.x |
|
Hey @joel-costigliola, of course, I can fix it to run on JDK 8. Will do it today. P.SL In contribution guidelines it is mentioned that the project needs to be built with JDK 17 |
|
We actually raised it to 21 for building it 🙃 but the language syntax and feature set that can be used in the code are still restricted to 8 |
mipo256
force-pushed
the
add-completable-future-assertion
branch
2 times, most recently
from
72e5f56
to
ff8ab54
Compare
…od with the value that satisfies condition
mipo256
force-pushed
the
add-completable-future-assertion
branch
from
ff8ab54
to
59bbca7
Compare
|
Thanks. guys, I've fixed it. Now the build should run just fine. FYI: @joel-costigliola, @scordio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
willCompleteWithValueMatchingmethod toAbstractCompletableFutureAssertto check thatCompletableFuturewill complete within the given period with value matching givenPredicate. Found this kind of assertion very handy in my project.