Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IterableAssert unroll the actual value for assertSame and assertNotSame #656

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/main/java/org/assertj/core/api/IterableAssert.java
Expand Up @@ -120,6 +120,24 @@ public IterableAssert<T> isNotExactlyInstanceOf(Class<?> type) {
}
return super.isNotExactlyInstanceOf(type);
}

@Override
public IterableAssert<T> isSameAs(Object expected) {
if (actual instanceof LazyIterable) {
objects.assertSame(info, asLazyIterable().iterator, expected);
return myself;
}
return super.isSameAs(expected);
}

@Override
public IterableAssert<T> isNotSameAs(Object expected) {
if (actual instanceof LazyIterable) {
objects.assertNotSame(info, asLazyIterable().iterator, expected);
return myself;
}
return super.isNotSameAs(expected);
}

@SuppressWarnings("rawtypes")
private LazyIterable asLazyIterable() {
Expand Down
Expand Up @@ -14,6 +14,7 @@

import static java.util.Arrays.asList;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
import static org.assertj.core.test.TestFailures.failBecauseExpectedAssertionErrorWasNotThrown;
import static org.assertj.core.util.Sets.newLinkedHashSet;
import static org.mockito.Mockito.mock;
Expand Down Expand Up @@ -128,6 +129,25 @@ public void isNotOfAnyClassIn_should_check_the_original_iterator() {
assertThat(stringIterator).isNotOfAnyClassIn(LazyIterable.class, String.class);
}

@Test
public void isSameAs_should_check_the_original_iterator_without_consuming_it() {
Iterator<?> iterator = mock(Iterator.class);
assertThat(iterator).isSameAs(iterator);
verifyZeroInteractions(iterator);
}

@Test
public void isNotSameAs_should_check_the_original_iterator_without_consuming_it() {
Iterator<?> iterator = mock(Iterator.class);
try{
assertThat(iterator).isNotSameAs(iterator);
} catch(AssertionError e){
verifyZeroInteractions(iterator);
return;
}
Assertions.fail("Expected assertionError, because assert notSame on same iterator.");
}

@Test
public void iterator_can_be_asserted_twice_even_though_it_can_be_iterated_only_once() {
Iterator<String> names = asList("Luke", "Leia").iterator();
Expand Down