Allow specifying the padding of the individual sprites in the group selector as well #201
Conversation
| await expect(spriteAsset.rawSrc, 'to have metadata satisfying', { | ||
| size: { | ||
| width: 12, | ||
| height: 90, |
There was a problem hiding this comment.
I'm a bit surprised about height 90. But I guess that would be padding behavior. I was more expecting a margin collapsing behavior, resulting in 50 being the result here.
I would expect if I set the padding property, I get that amount of empty space around each sprite. But I don't need double that. Since empty space is equal no matter if I'm looking at it from the perspective of one sprite or the other it should be fine. But I can see how that might be difficult to express for a sprite packer
There was a problem hiding this comment.
Yeah, I was also a bit 🤔 about it, but this is not really changing how the packers work, it just adds another way to apply it to a set of images.
I think I remember that the "Jim Scott" packer doesn't/can't easily support padding, but the horizontal and vertical packers should be easy to get to work the way you describe with collapsing of padding etc.
There was a problem hiding this comment.
@Munter, should we get this in and revisit the packer behavior separately?
There was a problem hiding this comment.
Yeah. This is better than before. Lets merge
|
Released in 3.2.0, update assetgraph-builder to it and released 8.0.1 of that. |
Discussed here: https://gitter.im/assetgraph/assetgraph-builder?at=5ec7b2262280c80cbfbfa4d7