New version of canvas (2.8.0) broke the build #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
|
@depfu rebase |
depfu
bot
force-pushed
the
depfu/check/npm/canvas-2.8.0
branch
from
b063ede
to
a5528d1
Compare
|
All good now, closing. |
|
All good now, closing. |
|
All good now, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested your project with an updated dependency and the build failed.
This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.
Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.
If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)
We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of canvas for this test run.
What changed?
✳️ canvas (^2.3.1 → 2.8.0) · Repo · Changelog
Release Notes
2.8.0 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 22 commits:
v2.8.0Add Node.js 16 to CI, remove 15export type NodeCanvasRenderingContext2DUpdate changelog to reflect previous commitAdd ctx2d.setTransform(mat) overloadAdd ctx2d.getTransform() functionUpdate changelog to reflect previous commitFix text actualBoundingBoxLeft and actualBoundingBoxRight measures by using ink_rect instead of logical_rectLoosen text measurement expectation.Fix crash if exception thrown from onload/onerrorUpdate changelogUse node pre gyp v1Fix always-false comparison warning in Canvas.cc in Node 15+Update changelogFix Windows CI build, add Node.js v15Fix dtslint failing in CIFix dangling reference in BackendOperationNotAvailable exception.add Dockerfile for linux prebuild imageAdded stride to the Typescript typingsFix PNG stream method name in benchmark (fixes #1672)Add invertSelf to the DOMMatrix object (#1649)translate "sans-serif" to "sans" for PangoDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands