Ensure _text is always available on JavaScript assets. #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of assetgraph 7.1.0 assignment to the .text property keeps the original source code available as _text. This is immensely useful but has also opened up an unfortunate inconsistency because _text is not populated from the rawSrc when such assets are instantiated. In order to avoid adding special cases to callers try to make _text uniformly available assetgraph is able to decode the raw buffer.
|
I'd rather not have to do this extra work in the constructor, |
|
Can you take a step back and explain the use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of assetgraph 7.1.0 assignment to the .text property keeps the
original source code available as _text. This is immensely useful
but has also opened up an unfortunate inconsistency because _text
is not populated from the rawSrc when such assets are instantiated.
In order to avoid adding special cases to callers try to make _text
uniformly available assetgraph is able to decode the raw buffer.