Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Logging #109

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Improve Logging #109

merged 2 commits into from
Mar 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2023

Original issue description

Current on install the log print the wrong "message". It says failed, should be success
and on uninstall it has wrong label on log (ERROR instead of INFO)

closes #108

@github-actions github-actions bot added the bug Something isn't working label Mar 8, 2023
@skin27 skin27 marked this pull request as ready for review March 8, 2023 14:25
@skin27 skin27 requested a review from brunovg March 8, 2023 14:25
Copy link
Collaborator

@brunovg brunovg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 👍🏻

@skin27 skin27 merged commit 67e316d into develop Mar 8, 2023
@skin27 skin27 deleted the bugfix/issue-108/improve-logging branch March 8, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants