Include timeout on flowStats #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…://github.com/assimbly/runtime into feature/issue-86/include-timeout-on-flowstats
skin27
reviewed
Feb 3, 2023
| flow.put("completed",completedMessages); | ||
| flow.put("failed",failedMessages); | ||
| flow.put("pending",pendingMessages); | ||
| flow.put("completedExchanges",completedMessages); |
There was a problem hiding this comment.
I'm trying to avoid the term "exchange". It's a concept of Camel, but not of Assimbly. Exchange is a difficult concept as it has a lifecycle and patterns. I want to simplify it to just speak of "messages". So I deliberately removed Exchange everywhere.
There was a problem hiding this comment.
Is this because Dovetail uses it. I think this concept is too difficult for Dovetail users.
There was a problem hiding this comment.
ok, I can change it.
I need to change this also on Dovetail, frontend and backend.
skin27
approved these changes
Feb 8, 2023
| @@ -1654,6 +1659,14 @@ public String getFlowStats(String flowId, boolean fullStats, boolean includeStep | |||
|
|
|||
| } | |||
|
|
|||
| private long getTimeout(CamelContext context) throws MalformedObjectNameException { | |||
There was a problem hiding this comment.
BTW Cool to add the timeout. Didn't how to do it. Seems a good addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
Include timeout on flowStats
closes #86