Skip to content

Commit

Permalink
Merge pull request #14 from assimp/master
Browse files Browse the repository at this point in the history
Update to upstream
  • Loading branch information
RichardTea committed Jul 2, 2019
2 parents fb8ee5e + ff662a6 commit 5009830
Show file tree
Hide file tree
Showing 27 changed files with 428 additions and 45 deletions.
3 changes: 3 additions & 0 deletions code/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ SOURCE_GROUP( Compiler FILES ${COMPILER_HEADERS})

SET( PUBLIC_HEADERS
${HEADER_PATH}/anim.h
${HEADER_PATH}/aabb.h
${HEADER_PATH}/ai_assert.h
${HEADER_PATH}/camera.h
${HEADER_PATH}/color4.h
Expand Down Expand Up @@ -668,6 +669,8 @@ SET( PostProcessing_SRCS
PostProcessing/MakeVerboseFormat.h
PostProcessing/ScaleProcess.cpp
PostProcessing/ScaleProcess.h
PostProcessing/GenBoundingBoxesProcess.cpp
PostProcessing/GenBoundingBoxesProcess.h
)
SOURCE_GROUP( PostProcessing FILES ${PostProcessing_SRCS})

Expand Down
4 changes: 2 additions & 2 deletions code/Collada/ColladaExporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ ColladaExporter::ColladaExporter( const aiScene* pScene, IOSystem* pIOSystem, co
, mFile(file) {
// make sure that all formatting happens using the standard, C locale and not the user's current locale
mOutput.imbue( std::locale("C") );
mOutput.precision(16);
mOutput.precision(ASSIMP_AI_REAL_TEXT_PRECISION);

mScene = pScene;
mSceneOwned = false;
Expand Down Expand Up @@ -1671,4 +1671,4 @@ void ColladaExporter::WriteNode( const aiScene* pScene, aiNode* pNode)
}

#endif
#endif
#endif
3 changes: 1 addition & 2 deletions code/Collada/ColladaExporter.h
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ class ColladaExporter
/// Stringstream to write all output into
std::stringstream mOutput;

protected:
/// The IOSystem for output
IOSystem* mIOSystem;

Expand Down Expand Up @@ -204,7 +203,7 @@ class ColladaExporter

std::map<unsigned int, std::string> textures;

protected:
public:
/// Dammit C++ - y u no compile two-pass? No I have to add all methods below the struct definitions
/// Reads a single surface entry from the given material keys
void ReadMaterialSurface( Surface& poSurface, const aiMaterial* pSrcMat, aiTextureType pTexture, const char* pKey, size_t pType, size_t pIndex);
Expand Down
4 changes: 1 addition & 3 deletions code/Collada/ColladaParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -323,10 +323,8 @@ void ColladaParser::ReadMetaDataItem(StringMetaData &metadata)
aiString aistr;
aistr.Set(value_char);
metadata.emplace(camel_key_str, aistr);
TestClosing(key_str.c_str());
}
else
SkipElement();
TestClosing(key_str.c_str());
}
else
SkipElement();
Expand Down
2 changes: 1 addition & 1 deletion code/Common/BaseProcess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ void BaseProcess::ExecuteOnScene( Importer* pImp)

// and kill the partially imported data
delete pImp->Pimpl()->mScene;
pImp->Pimpl()->mScene = NULL;
pImp->Pimpl()->mScene = nullptr;
}
}

Expand Down
3 changes: 3 additions & 0 deletions code/Common/Importer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -590,10 +590,12 @@ const aiScene* Importer::ReadFile( const char* _pFile, unsigned int pFlags)

// Find an worker class which can handle the file
BaseImporter* imp = NULL;
SetPropertyInteger("importerIndex", -1);
for( unsigned int a = 0; a < pimpl->mImporter.size(); a++) {

if( pimpl->mImporter[a]->CanRead( pFile, pimpl->mIOHandler, false)) {
imp = pimpl->mImporter[a];
SetPropertyInteger("importerIndex", a);
break;
}
}
Expand All @@ -606,6 +608,7 @@ const aiScene* Importer::ReadFile( const char* _pFile, unsigned int pFlags)
for( unsigned int a = 0; a < pimpl->mImporter.size(); a++) {
if( pimpl->mImporter[a]->CanRead( pFile, pimpl->mIOHandler, true)) {
imp = pimpl->mImporter[a];
SetPropertyInteger("importerIndex", a);
break;
}
}
Expand Down
7 changes: 7 additions & 0 deletions code/Common/PostStepRegistry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ corresponding preprocessor flag to selectively disable steps.
#if (!defined ASSIMP_BUILD_NO_GLOBALSCALE_PROCESS)
# include "PostProcessing/ScaleProcess.h"
#endif
#if (!defined ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS)
# include "PostProcessing/GenBoundingBoxesProcess.h"
#endif


namespace Assimp {

Expand Down Expand Up @@ -246,6 +250,9 @@ void GetPostProcessingStepInstanceList(std::vector< BaseProcess* >& out)
#if (!defined ASSIMP_BUILD_NO_IMPROVECACHELOCALITY_PROCESS)
out.push_back( new ImproveCacheLocalityProcess());
#endif
#if (!defined ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS)
out.push_back(new GenBoundingBoxesProcess);
#endif
}

}
4 changes: 2 additions & 2 deletions code/FBX/FBXConverter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1642,7 +1642,7 @@ namespace Assimp {
out_tex->pcData = reinterpret_cast<aiTexel*>(const_cast<Video&>(video).RelinquishContent());

// try to extract a hint from the file extension
const std::string& filename = video.FileName().empty() ? video.RelativeFilename() : video.FileName();
const std::string& filename = video.RelativeFilename().empty() ? video.FileName() : video.RelativeFilename();
std::string ext = BaseImporter::GetExtension(filename);

if (ext == "jpeg") {
Expand All @@ -1653,7 +1653,7 @@ namespace Assimp {
memcpy(out_tex->achFormatHint, ext.c_str(), ext.size());
}

out_tex->mFilename.Set(video.FileName().c_str());
out_tex->mFilename.Set(filename.c_str());

return static_cast<unsigned int>(textures.size() - 1);
}
Expand Down
2 changes: 1 addition & 1 deletion code/LWO/LWOLoader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1328,6 +1328,7 @@ void LWOImporter::LoadLWO2File()
bool skip = false;

LE_NCONST uint8_t* const end = mFileBuffer + fileSize;
unsigned int iUnnamed = 0;
while (true)
{
if (mFileBuffer + sizeof(IFF::ChunkHeader) > end)break;
Expand All @@ -1339,7 +1340,6 @@ void LWOImporter::LoadLWO2File()
break;
}
uint8_t* const next = mFileBuffer+head.length;
unsigned int iUnnamed = 0;

if(!head.length) {
mFileBuffer = next;
Expand Down
4 changes: 2 additions & 2 deletions code/Obj/ObjExporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ ObjExporter::ObjExporter(const char* _filename, const aiScene* pScene, bool noMt
// make sure that all formatting happens using the standard, C locale and not the user's current locale
const std::locale& l = std::locale("C");
mOutput.imbue(l);
mOutput.precision(16);
mOutput.precision(ASSIMP_AI_REAL_TEXT_PRECISION);
mOutputMat.imbue(l);
mOutputMat.precision(16);
mOutputMat.precision(ASSIMP_AI_REAL_TEXT_PRECISION);

WriteGeometryFile(noMtl);
if ( !noMtl ) {
Expand Down
2 changes: 1 addition & 1 deletion code/Ply/PlyExporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ PlyExporter::PlyExporter(const char* _filename, const aiScene* pScene, bool bina
// make sure that all formatting happens using the standard, C locale and not the user's current locale
const std::locale& l = std::locale("C");
mOutput.imbue(l);
mOutput.precision(16);
mOutput.precision(ASSIMP_AI_REAL_TEXT_PRECISION);

unsigned int faces = 0u, vertices = 0u, components = 0u;
for (unsigned int i = 0; i < pScene->mNumMeshes; ++i) {
Expand Down
115 changes: 115 additions & 0 deletions code/PostProcessing/GenBoundingBoxesProcess.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
/*
---------------------------------------------------------------------------
Open Asset Import Library (assimp)
---------------------------------------------------------------------------
Copyright (c) 2006-2019, assimp team
All rights reserved.
Redistribution and use of this software in source and binary forms,
with or without modification, are permitted provided that the following
conditions are met:
* Redistributions of source code must retain the above
copyright notice, this list of conditions and the
following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the
following disclaimer in the documentation and/or other
materials provided with the distribution.
* Neither the name of the assimp team, nor the names of its
contributors may be used to endorse or promote products
derived from this software without specific prior
written permission of the assimp team.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
---------------------------------------------------------------------------
*/

#ifndef ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS

#include "PostProcessing/GenBoundingBoxesProcess.h"

#include <assimp/postprocess.h>
#include <assimp/scene.h>

namespace Assimp {

GenBoundingBoxesProcess::GenBoundingBoxesProcess()
: BaseProcess() {

}

GenBoundingBoxesProcess::~GenBoundingBoxesProcess() {
// empty
}

bool GenBoundingBoxesProcess::IsActive(unsigned int pFlags) const {
return 0 != ( pFlags & aiProcess_GenBoundingBoxes );
}

void checkMesh(aiMesh* mesh, aiVector3D& min, aiVector3D& max) {
ai_assert(nullptr != mesh);

if (0 == mesh->mNumVertices) {
return;
}

for (unsigned int i = 0; i < mesh->mNumVertices; ++i) {
const aiVector3D &pos = mesh->mVertices[i];
if (pos.x < min.x) {
min.x = pos.x;
}
if (pos.y < min.y) {
min.y = pos.y;
}
if (pos.z < min.z) {
min.z = pos.z;
}

if (pos.x > max.x) {
max.x = pos.x;
}
if (pos.y > max.y) {
max.y = pos.y;
}
if (pos.z > max.z) {
max.z = pos.z;
}
}
}

void GenBoundingBoxesProcess::Execute(aiScene* pScene) {
if (nullptr == pScene) {
return;
}

for (unsigned int i = 0; i < pScene->mNumMeshes; ++i) {
aiMesh* mesh = pScene->mMeshes[i];
if (nullptr == mesh) {
continue;
}

aiVector3D min(999999, 999999, 999999), max(-999999, -999999, -999999);
checkMesh(mesh, min, max);
mesh->mAABB.mMin = min;
mesh->mAABB.mMax = max;
}
}

} // Namespace Assimp

#endif // ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS
76 changes: 76 additions & 0 deletions code/PostProcessing/GenBoundingBoxesProcess.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
/*
---------------------------------------------------------------------------
Open Asset Import Library (assimp)
---------------------------------------------------------------------------
Copyright (c) 2006-2019, assimp team
All rights reserved.
Redistribution and use of this software in source and binary forms,
with or without modification, are permitted provided that the following
conditions are met:
* Redistributions of source code must retain the above
copyright notice, this list of conditions and the
following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the
following disclaimer in the documentation and/or other
materials provided with the distribution.
* Neither the name of the assimp team, nor the names of its
contributors may be used to endorse or promote products
derived from this software without specific prior
written permission of the assimp team.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
---------------------------------------------------------------------------
*/

/** @file Defines a post-processing step to generate Axis-aligned bounding
* volumes for all meshes.
*/

#pragma once

#ifndef AI_GENBOUNDINGBOXESPROCESS_H_INC
#define AI_GENBOUNDINGBOXESPROCESS_H_INC

#ifndef ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS

#include "Common/BaseProcess.h"

namespace Assimp {

/** Post-processing process to find axis-aligned bounding volumes for amm meshes
* used in a scene
*/
class ASSIMP_API GenBoundingBoxesProcess : public BaseProcess {
public:
/// The class constructor.
GenBoundingBoxesProcess();
/// The class destructor.
~GenBoundingBoxesProcess();
/// Will return true, if aiProcess_GenBoundingBoxes is defined.
bool IsActive(unsigned int pFlags) const override;
/// The execution callback.
void Execute(aiScene* pScene) override;
};

} // Namespace Assimp

#endif // #ifndef ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS

#endif // AI_GENBOUNDINGBOXESPROCESS_H_INC
7 changes: 3 additions & 4 deletions code/PostProcessing/SplitLargeMeshes.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Open Asset Import Library (assimp)
Copyright (c) 2006-2019, assimp team
All rights reserved.
Redistribution and use of this software in source and binary forms,
Expand Down Expand Up @@ -40,7 +39,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
----------------------------------------------------------------------
*/

/** @file Defines a post processing step to split large meshes into submeshes
/** @file Defines a post processing step to split large meshes into sub-meshes
*/
#ifndef AI_SPLITLARGEMESHES_H_INC
#define AI_SPLITLARGEMESHES_H_INC
Expand All @@ -51,10 +50,10 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include <assimp/mesh.h>
#include <assimp/scene.h>

// Forward declarations
class SplitLargeMeshesTest;

namespace Assimp
{
namespace Assimp {

class SplitLargeMeshesProcess_Triangle;
class SplitLargeMeshesProcess_Vertex;
Expand Down
2 changes: 1 addition & 1 deletion code/STL/STLExporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ STLExporter::STLExporter(const char* _filename, const aiScene* pScene, bool expo
// make sure that all formatting happens using the standard, C locale and not the user's current locale
const std::locale& l = std::locale("C");
mOutput.imbue(l);
mOutput.precision(16);
mOutput.precision(ASSIMP_AI_REAL_TEXT_PRECISION);
if (binary) {
char buf[80] = {0} ;
buf[0] = 'A'; buf[1] = 's'; buf[2] = 's'; buf[3] = 'i'; buf[4] = 'm'; buf[5] = 'p';
Expand Down
Loading

0 comments on commit 5009830

Please sign in to comment.