Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS on the Hurd #1642

Closed
umlaeute opened this issue Dec 14, 2017 · 5 comments · Fixed by #1673
Closed

FTBFS on the Hurd #1642

umlaeute opened this issue Dec 14, 2017 · 5 comments · Fixed by #1673

Comments

@umlaeute
Copy link
Contributor

umlaeute commented Dec 14, 2017

In o3dgcTimer.h#L33 there are some includes protected by an #ifdef __MACH__:

#elif __MACH__
#include <mach/clock.h>
#include <mach/mach.h>
#else
#include <time.h>
#include <sys/time.h>
#endif

It seems that this is intended for OSX/macOS.
However there are other implementations of the Mach Microkernel, notably GNU Hurd, which lacks the mach/clock.h include.
Therefore this file cannot be built on the Hurd.

If the define was indeed meant for OSX/macOS, I suggest to use __APPLE__ instead:

#elif __APPLE__
#include <mach/clock.h>
#include <mach/mach.h>
#else
#include <time.h>
#include <sys/time.h>
#endif
@umlaeute
Copy link
Contributor Author

I've also reported this KhronosGroup/COLLADA2GLTF#103 (I guess the code has been taken from there). Nevertheless it would be nice if you could fix that locally as well.

@kimkulling
Copy link
Member

The code came with the glFT-importer. I will take a look.

@umlaeute
Copy link
Contributor Author

I just discovered that the proposed fix (replacing __MACH__ with __APPLE__) is not enough to make assimp build on the Hurd.
I'll try to find a real solution in the next days.

@kimkulling
Copy link
Member

Great, thanks a lot for your time and work!

@umlaeute
Copy link
Contributor Author

ah, found the problem.

in that file, there seem to be two occurences of __MACH__, and both of them have to be replaced with __APPLE__.

See the Debian patch that allows to successfully build assimp on the Hurd.

kimkulling added a commit that referenced this issue Jan 2, 2018
closes #1642: fix build on Hurd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants