Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystemFilter should forward all interface functions to wrapped IOSystem instance #1773

Closed
mabuchner opened this issue Feb 6, 2018 · 0 comments
Closed

FileSystemFilter should forward all interface functions to wrapped IOSystem instance #1773

mabuchner opened this issue Feb 6, 2018 · 0 comments

Comments

@mabuchner
Copy link
Contributor

I'm trying to override the IOSystem::PushDirectory, IOSystem::CurrentDirectory, IOSystem::StackSize and IOSystem::PopDirectory functions. Sadly my overloads are never called.

The problem seems to be, that the BaseImporter::ReadFile function wraps my IOSystem instance inside a FileSystemFilter and the FileSystemFilter doesn't forward the above mentioned functions to my IOSystem instance. Therefore just the default implementations will be called.

Other virtual IOSystem functions (IOSystem::CreateDirectory, IOSystem::ChangeDirectory and IOSystem::DeleteFile) probably also can't be overridden.
@mabuchner mabuchner mentioned this issue Feb 6, 2018
Open
mabuchner pushed a commit to mabuchner/assimp that referenced this issue Feb 12, 2018
Make FileSystemFilter forward all virtual functions to wrapped IOSyst…
60267f9 
…em instance

This makes it possible to override those functions. Previously the
default implementation was always used.

Fixes assimp#1773
@mabuchner mabuchner mentioned this issue Feb 12, 2018
Merged
mabuchner pushed a commit to mabuchner/assimp that referenced this issue Feb 12, 2018
Make FileSystemFilter forward all virtual functions to wrapped IOSyst…
1299905 
…em instance

This makes it possible to override those functions. Previously the
default implementation was always used.

Fixes assimp#1773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mabuchner