Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXEC_BAD_ACCESS after attempt to import some COLLADA models #2548

Closed
vfiloretov opened this issue Jul 15, 2019 · 1 comment
Closed

EXEC_BAD_ACCESS after attempt to import some COLLADA models #2548

vfiloretov opened this issue Jul 15, 2019 · 1 comment

Comments

@vfiloretov
Copy link

When I try to import attack.dae model I get EXEC_BAD_ACCESS.

It happens at some moment when pData.mValues.size() == 0 and we dereference pData.mValues[pos] in return statement.

<source id="SID_64">
     <float_array id="SID_64-array" count="0"/>
     <technique_common>
      <accessor source="#SID_64-array" count="0" stride="1">
       <param name="WEIGHT" type="float"/>
      </accessor>
     </technique_common>
    </source>

I tried to investigate and found it. What you think about adding zero size check?
@kimkulling
Copy link
Member

I found a solution for that bug. Pull request is under preparation.

kimkulling added a commit that referenced this issue Jul 16, 2019
@kimkulling
Merge pull request #2549 from assimp/issue_2548
fed764d 
closes #2548: check if weight …
thomasbiang pushed a commit to thomasbiang/assimp that referenced this issue Jul 25, 2019
@kimkulling @ywangsc
Initial parsing for header and more.
a052a88 
JT: Inital commit.

JT: next steps.

closes assimp#2368: add missign anim mesh for multimaterial meshes in fbx,.

Remove not needed init.

closes assimp#2527: use correct macro for Assimp-exporter.

closes assimp#2439: add null ptr test before calling hasAttr.

closes code/Collada/ColladaLoader.cpp: fix possible memleak when throwing an exception.

Update ColladaLoader.cpp

- add header memory
- Fix format stuff

Assjson: add json export to list of exporters.

Update FBXConverter.cpp

Fix merge conflicts

Update JTImporter.cpp

disable unused method,.

Update CMakeLists.txt

remove jtimporter

Delete JTImporter.cpp

Remove JTImorter.cpp from pull request

Delete JTImporter.h

Add unittest for json.

Fix missing doc in config.h

- Fixed anim meshes generated from blendshapes not being copied to output for multi-material meshes
- Fixed first vertex of each blendshape on a multi-material mesh having all unmapped vertice offsets being added to it
- Fixed blendshapes not importing for multi-material FBX meshes with no bones

closes assimp#2548: check if weight are set or set the weight to 1.0f

set->unordered_set;unsigned int for iteration

customize error rate for bind pose

clean up

use ExportProperties to customize bind pose epsilon

customize error rate for bind pose

clean up

update

customize error rate for bind pose

clean up

use ExportProperties to customize bind pose epsilon

customize error rate for bind pose

clean up

use ExportProperties to customize bind pose epsilon

update

Fix line continuations in OBJ files

Add unit test for OBJ line continuations

Unit: Fix new compiler warnings.

Unit: fix more compiler warnings.

Fix another signed / unsigned comparison warning.

change std::array<int, x > to std::array<unsigned int, x> to fix compiler warnings.

Fix another signed unsigned comparison warning.

Update utBlenderWork.cpp

Fix compiler warning signed against unsigned.

Update UnrealLoader.h

use memcpy instead of = operator for pos copy.

Update utIssues.cpp

use correct test for floats.

Fix issue assimp#2557

Update FBXExporter.cpp

Fix review finding.

Initial parsing for header and more.

JT: Inital commit.

JT: next steps.

Update ColladaLoader.cpp

- add header memory
- Fix format stuff

Assjson: add json export to list of exporters.

Update JTImporter.cpp

disable unused method,.
badaninm added a commit to bear2b/assimp that referenced this issue Oct 24, 2019
@badaninm
Merge branch 'master' of github.com:bear2b/assimp into old_assimp_gltf
8155fdf 
* 'master' of github.com:bear2b/assimp: (367 commits)
  closes assimp#2548: check if weight are set or set the weight to 1.0f
  - Fixed anim meshes generated from blendshapes not being copied to output for multi-material meshes - Fixed first vertex of each blendshape on a multi-material mesh having all unmapped vertice offsets being added to it - Fixed blendshapes not importing for multi-material FBX meshes with no bones
  Fix missing doc in config.h
  Add unittest for json.
  Delete JTImporter.h
  Delete JTImporter.cpp
  Update CMakeLists.txt
  Update JTImporter.cpp
  Update FBXConverter.cpp
  Assjson: add json export to list of exporters.
  Update ColladaLoader.cpp
  closes code/Collada/ColladaLoader.cpp: fix possible memleak when throwing an exception.
  Remove not needed init.
  closes assimp#2439: add null ptr test before calling hasAttr.
  Update FBXConverter.cpp
  closes assimp#2368: just fix it
  closes assimp#2527: use correct macro for Assimp-exporter.
  Fix a GCC 9 warning:
  initial unnamed node uniqueness index outside of loop
  all textures use relative path except embedded, this is fix for it
  ...

# Conflicts:
#	code/CMakeLists.txt
#	port/iOS/build.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimkulling @vfiloretov