Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] FBX Crash on import #2614

Closed
RevoluPowered opened this issue Aug 22, 2019 · 2 comments
Closed

[Patch] FBX Crash on import #2614

RevoluPowered opened this issue Aug 22, 2019 · 2 comments
Labels
Bug Global flag to mark a deviation from expected behaviour FBX Bugs related to the FBX format

Comments

@RevoluPowered
Copy link
Collaborator

RevoluPowered commented Aug 22, 2019

Just putting this here so I don't forget to fix this happening and segfault happening on NVIDIA models.

---------------- thirdparty/assimp/code/FBX/FBXMeshGeometry.cpp ----------------
index e60fc25e24..874cee52e0 100644
@@ -610,7 +610,11 @@ void MeshGeometry::ReadVertexDataMaterials(std::vector<int>& materials_out, cons
     const std::string& ReferenceInformationType)
 {
     const size_t face_count = m_faces.size();
-    ai_assert(face_count);
+    if(face_count == 0)
+    {
+        return;
+    }
@RevoluPowered RevoluPowered changed the title [Patch] [Patch] FBX Crash on import Aug 22, 2019
@kimkulling kimkulling added Bug Global flag to mark a deviation from expected behaviour FBX Bugs related to the FBX format labels Aug 26, 2019
@kimkulling
Copy link
Member

Ok, I will take care! Thanks for the bug report.

RevoluPowered added a commit to RevoluPowered/assimp that referenced this issue Aug 26, 2019
RevoluPowered added a commit to RevoluPowered/assimp that referenced this issue Aug 26, 2019
@RevoluPowered
Copy link
Collaborator Author

Patch created :)

RevoluPowered added a commit to RevoluPowered/godot that referenced this issue Aug 26, 2019
RevoluPowered added a commit to RevoluPowered/godot that referenced this issue Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Global flag to mark a deviation from expected behaviour FBX Bugs related to the FBX format
Projects
None yet
Development

No branches or pull requests

2 participants