Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible AMF regression #3678

Closed
tellypresence opened this issue Feb 26, 2021 · 2 comments · Fixed by #3736
Closed

Possible AMF regression #3678

tellypresence opened this issue Feb 26, 2021 · 2 comments · Fixed by #3736
Labels
AMF Bugs related to the AMF format. Bug Global flag to mark a deviation from expected behaviour
Projects
Planning for Release V5.1
Milestone
Release 5.1

Comments

@tellypresence
Copy link
Contributor

tellypresence commented Feb 26, 2021 •
edited

Extracted bundled model archive
test/models-nonbsd/AMF/3_bananas.amf.7z
to
test/models-nonbsd/AMF/3_bananas.amf/3_bananas.amf
but failed to load with message

Attribute "Millimeters" in node <unit> has incorrect value.

Last year this model at least loaded successfully but rendered with serious artefacts, so not sure if this is a regression or an improvement where now a problematic model is being correctly rejected.
@kimkulling kimkulling added AMF Bugs related to the AMF format. Bug Global flag to mark a deviation from expected behaviour labels Feb 28, 2021
@kimkulling kimkulling added this to the Release 5.1 milestone Feb 28, 2021
@kimkulling kimkulling added this to ToDo in Planning for Release V5.1 via automation Feb 28, 2021
@kimkulling
Copy link
Member

Could be an xml-mgration issue. I will test it.

@kimkulling
Copy link
Member

Problem is caused by an upper-/lower-case confusion of the AMF-parsing. I am currently preparing a fix for that.

kimkulling added a commit that referenced this issue Mar 10, 2021
@kimkulling
Merge pull request #3694 from assimp/issue_3678
cdd0fea 
closes #3678: ensure lowercase
Planning for Release V5.1 automation moved this from ToDo to Done Mar 10, 2021
@tellypresence tellypresence mentioned this issue Mar 11, 2021
Closed
@kimkulling kimkulling reopened this Mar 14, 2021
Planning for Release V5.1 automation moved this from Done to ToDo Mar 14, 2021
@kimkulling kimkulling mentioned this issue Apr 3, 2021
Merged
Planning for Release V5.1 automation moved this from ToDo to Done Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AMF Bugs related to the AMF format. Bug Global flag to mark a deviation from expected behaviour
Projects
No open projects
Planning for Release V5.1
  
Done
Milestone
Release 5.1
Development

Successfully merging a pull request may close this issue.

Issue 3678 assimp/assimp
2 participants
@kimkulling @tellypresence