Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiProcess_LimitBoneWeights "removes empty bones" #4840

Closed
vergol opened this issue Dec 13, 2022 · 1 comment · Fixed by #4895
Closed

aiProcess_LimitBoneWeights "removes empty bones" #4840

vergol opened this issue Dec 13, 2022 · 1 comment · Fixed by #4895
Labels
Feature-Request Global flag to mark feature requests

Comments

@vergol
Copy link

vergol commented Dec 13, 2022

Can you consider removing this part?

assimp/code/PostProcessing/LimitBoneWeightsProcess.cpp

Line 173 in de83245

// remove empty bones

Or at least check for AI_CONFIG_IMPORT_REMOVE_EMPTY_BONES here?
@vergol vergol added the Feature-Request Global flag to mark feature requests label Dec 13, 2022
kimkulling added a commit that referenced this issue Jan 20, 2023
@kimkulling
Update LimitBoneWeightsProcess.cpp
ab0a119 
- Removing empty bones only if AI_CONFIG_IMPORT_REMOVE_EMPTY_BONES is enabled.
- closes #4840
@kimkulling kimkulling mentioned this issue Jan 20, 2023
Merged
@kimkulling
Copy link
Member

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature-Request Global flag to mark feature requests
Projects
The Asset-Importer-Lib Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update LimitBoneWeightsProcess.cpp assimp/assimp
2 participants
@kimkulling @vergol