Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vs-2017 warnings #2371

Merged
merged 6 commits into from
Mar 17, 2019
Merged

Fix vs-2017 warnings #2371

merged 6 commits into from
Mar 17, 2019

Conversation

kimkulling
Copy link
Member

  • fix warn-level 3 warnings in vs2017
  • fix some warn-level 4 warnings in vs2017
  • fix coverity findings.

@coveralls
Copy link

coveralls commented Mar 14, 2019

Coverage Status

Coverage decreased (-0.002%) to 48.088% when pulling 718b5b2 on fix_vs107_warnings into 2f6aa24 on master.

@kimkulling
Copy link
Member Author

This pull request fixes 2 alerts when merging 61ffe01 into d9e81cb - view on LGTM.com

fixed alerts:

  • 2 for Comparison result is always the same

Comment posted by LGTM.com

@kimkulling
Copy link
Member Author

This pull request fixes 2 alerts when merging a0c797a into ef27022 - view on LGTM.com

fixed alerts:

  • 2 for Comparison result is always the same

Comment posted by LGTM.com

@kimkulling kimkulling changed the title Fix vs107 warnings Fix vs-2017 warnings Mar 16, 2019
@kimkulling
Copy link
Member Author

This pull request fixes 2 alerts when merging 718b5b2 into 2f6aa24 - view on LGTM.com

fixed alerts:

  • 2 for Comparison result is always the same

Comment posted by LGTM.com

@kimkulling kimkulling merged commit e899067 into master Mar 17, 2019
@kimkulling kimkulling deleted the fix_vs107_warnings branch December 6, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants