bad OBJ file that can still be read #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a bad OBJ file that has the following structure:
The file obviously misses texture coordinates, but the "face" lines seem addressing normals instead. The parser fails on this by skipping the first digit after the slash, which leads to various harmful consequences...
It is discussable if the second number of each pair should be ignored or treated as a normal index instead of UV index, but the parser may (and so should) read the file at least partially.
This pull request sorts it out by checking if the currently read number should be a UV index, but the mesh has only normals and uses the number as the normal index instead. It passes all the tests and I added another one representing the file I have. Unfortunately I can't provide the file itself because of its size and unknown copyright status.