Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragmented FBX ASCII emdedded resource #2466

Merged

Conversation

muxanickms
Copy link
Contributor

Base64 encoded data in FBX ASCII format could be split into multiple chunks by 512Kb size, when decoding it should be accumulated in one buffer.
Make code little bit faster in terms of allocations, added unit test for it as well.
Sample FBX looks like that:

		Filename: "U:/Some/Absolute/Path/paper.png"
		RelativeFilename: "paper.png"
		Content: ,
 "iVBORw0KGgoAAAANSUhEUgAABAAAAAQACAIAAADwf7zUAAAACXB...
 "N7eDUphJ7gxutqfsCDkA+NQ2APoZsmjfiC2KidzqmOGYMzoHZaa....
	}
	Texture: 1826343863344, "Texture::Map #2", "" {

@muxanickms muxanickms force-pushed the topic/fragmented_embedded_textures branch from 2f97b6e to 6c13ec8 Compare May 16, 2019 10:59
@kimkulling kimkulling merged commit 0e8444b into assimp:master May 21, 2019
@kimkulling
Copy link
Member

Merged, thanks a lot for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants