Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All textures use relative path except embedded textures, this is a fix for it #2523

Merged
merged 2 commits into from
Jun 30, 2019

Conversation

muxanickms
Copy link
Contributor

FBXConverter::GetTexturePath returns RelativeFilename() for all textures (this is stored in the material $tex.name), but FBXConverter::ConvertVideo returns FileName() as a texture name, so it's very hard to match both strings in run-time to figure out which embedded texture it is.
I propose to use relative path everywhere, that helps a lot.

@kimkulling kimkulling merged commit ff662a6 into assimp:master Jun 30, 2019
@kimkulling
Copy link
Member

Merged, thanks a lot for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants