closes https://github.com/assimp/assimp/issues/3007 #3008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kimkulling
commented
Feb 13, 2020
kimkulling
commented
- Remove named ELSE and ENDIF statements from cmakefiles.
- Set required cmake version up to 3.0
malortie
pushed a commit
to malortie/assimp
that referenced
this pull request
Feb 26, 2020
This is a follow-up to PR assimp#3024, in which I explained that I would then change the version of CMake to 3.0 in several files to match the changes that were originally made by OP in PR assimp#3008. The minimum CMake version have been raised to 3.0 in both assimp_cmd and assimp_view projects. The same CMake configuration as in PR assimp#3024 was used. All projects from PR assimp#3024 are found in the solution with the current changes. All projects built. All tests were run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.