Allow dlclose of so library by avoiding unique symbols. #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This breaks binary compatibility on all platforms. May also affect language wrappers, unsure what they do for inlined functions. |
|
So we need to merge this later on. |
|
OK, lets increase the minor release number and try to get lot of feature into it. |
|
Merged, thans a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libassimp.so library contains one symbol of type STB_GNU_UNIQUE, meaning that the library can not be unloaded with dlclose after it has been loaded with dlopen. If a plugin links with the assimp library, this plugin will not be able to unload either.
The following symbol is the problem:
nm -DC /lib/x86_64-linux-gnu/libassimp.so.5.0.0 | grep " u "
0000000000c40f20 u Assimp::IOSystem::CurrentDirectoryabi:cxx11 const::Dummy
A simple fix will be to remove the inlining of this function.