Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a few crashes when running
assimp info
on the test-models.notably:
LWOImporter
: it seems there was a typo, swappingj
fori
(loop-vars rock!), which would create an out-of-bounds access on a vectorRemoveRedundantMatsProcess
: this crashed on an assertion (that there are actually materials left after removing all the redundant ones). i replaced the assertion by a throwing aDeadlyImportError
ImportErrorException
:assimp/code/Common/BaseProcess.h
Lines 217 to 224 in 70f5cca
however, there is no such exception and other postprocessors used the
DeadlyImportError
, so i used that one as well (probably the docs should be updated)