CMake: Replace CMAKE_COMPILER_IS_MINGW by MINGW #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has been tested here: https://github.com/xmake-io/xmake-repo/runs/4650952688 |
|
Look good. I will merge it when the CI-build is ready. |
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assimp can't detect MinGW with CMake >=3.21 because CMAKE_COMPILER_IS_MINGW got removed, thus won't set some flags such as
-Wa,-mbig-objwhich are required for compilation.This commit replaces CMAKE_COMPILER_IS_MINGW with MINGW variable (which appeared in CMake 3.2, so this should be fine).
Please note I haven't tested if that android hack for MinGW still works.