cmake: Fix assimp target install rule fully specifying component #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures generated install rules for the assimp target are all consistently associated with components named after LIBASSIMP_COMPONENT or LIBASSIMP-DEV_COMPONENT CMake variables. It streamlines the packaging of specific components of assimp in client projects leveraging the CPACK_INSTALL_CMAKE_PROJECTS variable. Failing to do so leads to "/path/to/assimp-build/code/cmake_install.cmake" file having install rules associated with a component called "Unspecified". See https://cmake.org/cmake/help/v3.10/command/install.html#installing-targets and https://cmake.org/cmake/help/v3.22/module/CPack.html#variable:CPACK_INSTALL_CMAKE_PROJECTS
|
Merged, thanks a lot for your contribution. |
jcfr
deleted the
fix-assimp-target-install-rule-fully-specifying-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures generated install rules for the
assimptarget areall consistently associated with components named after
LIBASSIMP_COMPONENTor
LIBASSIMP-DEV_COMPONENTCMake variables.It streamlines the packaging of specific components of assimp in client
projects leveraging the
CPACK_INSTALL_CMAKE_PROJECTSvariable.Failing to do so leads to
/path/to/assimp-build/code/cmake_install.cmakefile having install rules associated with a component called
Unspecified.See https://cmake.org/cmake/help/v3.10/command/install.html#installing-targets
and https://cmake.org/cmake/help/v3.10/module/CPack.html#variable:CPACK_INSTALL_CMAKE_PROJECTS