Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added Obj model support for the bump map -bm #### multiplier. I've attempted to follow the gltf use of "$tex.scale" as a guide for making it available.
An example Obj line with the parameter:
map_Bump -bm 0.398056 textures\main_normal.png
These changes will load the 0.398056 factor into a material property for either Normal or Height maps (ie: Obj map_Bump). The property is only set if the scalar is not 1.0.
The property can be retrieved like so:
aiMaterial* mtl = scene->mMaterials[m];
ai_real bm = 1.0;
aiReturn rc = aiReturn_SUCCESS;
if( mtl->GetTexture(aiTextureType_NORMALS, texIndex, &path) == AI_SUCCESS) {
rc = aiGetMaterialFloat(mtl, AI_MATKEY_OBJ_BUMPMULT_NORMALS(0), &bm);
}
else if(mtl->GetTexture(aiTextureType_HEIGHT, texIndex, &path) == AI_SUCCESS) {
rc = aiGetMaterialFloat(mtl, AI_MATKEY_OBJ_BUMPMULT_HEIGHT(0), &bm);
}