Expose the original OBJ "illum" value #4409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the original Obj model
illum
value (illumination_model) as a material property.The
illum
value is defined in a .mtl material file like so:illum 3
Background:
ObjFileImporter::createMaterials
inObjFileImporter.cpp
partially interprets the illum value as anaiShadingMode
enum and stores it in theAI_MATKEY_SHADING_MODEL
material property. Illumination model values 3 thru 10 are lost in the interpretation. Exposing the original illum value allows user interpretation of the intended model.Example accessor usage:
aiScene* scene = ...
int illum = 1;
aiMaterial* mtl = scene->mMaterials[m];
aiGetMaterialInteger(mtl, AI_MATKEY_OBJ_ILLUM, &illum);