Added support for more bone weights in GLTF2 #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GLTF2 importer doesn't actually read beyond the first four bone weights (first attribute). This patch expands the parser to store as many bone weights as are available in the file.
|
The existing GLTF2 code only parses the first joints/weights attribute, but a file with more weights will have additional attributes that get ignored. This PR loads an arbitrary number of them. I tried to write this with as little disturbance to the existing code as possible, but I'm not 100% sure that this array-of-arrays setup was the best way to do this. This is essentially a follow-up to #4451, which ensures that the load doesn't fail on a file with extended weights but also doesn't parse them. I have a test file I can share privately if you'd like to take a look, just let me know. |
SirLynix
reviewed
Mar 22, 2022
kimkulling
requested changes
Apr 19, 2022
kimkulling
approved these changes
Aug 16, 2022
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GLTF2 importer doesn't actually read beyond the first four bone weights (first attribute). This patch expands the parser to read as many bone weights as are available in the file.