Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Roughness factor exported by Blender #4466

Merged
merged 2 commits into from Apr 2, 2022
Merged

Detect Roughness factor exported by Blender #4466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4175198
Detect Roughness factor exported by Blender
ifiddynine Mar 26, 2022
88dadd6
Merge branch 'master' into patch-3
kimkulling Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions code/AssetLib/FBX/FBXConverter.cpp
View file
Open in desktop
Expand Up @@ -2161,6 +2161,9 @@ void FBXConverter::SetShadingPropertiesCommon(aiMaterial *out_mat, const Propert
const float ShininessExponent = PropertyGet<float>(props, "ShininessExponent", ok);
if (ok) {
out_mat->AddProperty(&ShininessExponent, 1, AI_MATKEY_SHININESS);
// Match Blender behavior to extract roughness when only shininess is present
const float roughness = 1.0 - (sqrt(ShininessExponent) / 10.0);
out_mat->AddProperty(&roughness, 1, AI_MATKEY_ROUGHNESS_FACTOR);
}

// TransparentColor / TransparencyFactor... gee thanks FBX :rolleyes:
Expand Down